(CAT-2061) Fix empty string nullification #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Clebam Could you confirm that this is what you had in mind for your suggested fix on the revert PR? |
Reinstating reverted change by Clebam with additional fix suggested by original author. Original PR: #292 Revert PR: #342 Reason for revert: #340 Original author: https://github.com/Clebam
david22swan
force-pushed
the
CAT-2061
branch
from
ac1a76a
to
ccd3b58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 6 6
Lines 720 720
=======================================
Hits 663 663
Misses 57 57 ☔ View full report in Codecov by Sentry. |
|
Hi @david22swan, Yes indeed. The purpose of this piece of code is to avoid sending a Originally my regex was a bit to wide an included The fix should properly only aim at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstating reverted change by Clebam with additional fix suggested by original author.
Original PR: #292
Revert PR: #342
Reason for revert: #340
Original author: https://github.com/Clebam
Checklist